Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add network filter to top collection #8817

Merged
merged 12 commits into from
Jan 3, 2024
Merged

feat: Add network filter to top collection #8817

merged 12 commits into from
Jan 3, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 1, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-01 at 11 51 24

Copilot Summary

copilot:summary

copilot:poem

@hassnian hassnian requested a review from a team as a code owner January 1, 2024 06:50
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team January 1, 2024 06:50
@netlify Netlify
Copy link

netlify bot commented Jan 1, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7669fd4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65954f05ad89a500086819eb
😎 Deploy Preview https://deploy-preview-8817--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 1, 2024

WARNING @hassnian PR for issue #8816 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8816

@hassnian hassnian changed the title add: Add network filter to top collection feat: Add network filter to top collection Jan 1, 2024
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Jan 1, 2024

AI-Generated Summary: This pull request includes three patches.

The first patch introduces a new feature in ChainDropdown.vue and TopCollections.vue, adding a new function 'chain dropdown' and making some changes on the frontend.

The second patch is a refactoring in useTopCollections.ts to improve the code. The refactoring involved changing the handling of loading states in the top collections component, and making it able to refresh automatically when urlPrefix changes.

The third patch includes both fixes and feature modifications. It allows disabling redirect on chain change by modifying the properties in ChainDropdown.vue. In TopCollections.vue, the loading state appearance was significantly updated with a new layout design while the old one was removed. A default loading state was added in useTopCollections.ts.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jan 1, 2024
@exezbcz
Copy link
Member

exezbcz commented Jan 1, 2024

uwu nice!

could you please align it

image

@hassnian
Copy link
Contributor Author

hassnian commented Jan 1, 2024 •
edited
Loading

@exezbcz check again, thanks

@exezbcz
Copy link
Member

exezbcz commented Jan 1, 2024

last thing, mobile

image

@exezbcz exezbcz added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jan 1, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Jan 1, 2024

last thing, mobile

image

can you elaborate? margin missing or/and should be at the end of the row

thanks

@exezbcz
Copy link
Member

exezbcz commented Jan 1, 2024

@hassnian yeah margin under the network button

preschian
preschian approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

roiLeo
roiLeo approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

components/landing/topCollections/TopCollections.vue Outdated Show resolved Hide resolved
components/landing/topCollections/TopCollections.vue Outdated Show resolved Hide resolved
@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Jan 2, 2024
@Jarsen136 Jarsen136 requested a review from exezbcz January 2, 2024 12:42
@exezbcz
Copy link
Member

exezbcz commented Jan 2, 2024

hmmm, lets remove rmrk2 from the options, the top collection section is not visible on the network

image
  • would be nice if we would have top collections for rmrk2 as well, but not prio

@roiLeo
Copy link
Contributor

roiLeo commented Jan 2, 2024

would be nice if we would have top collections for rmrk2 as well, but not prio

not so easy to do, this one is blocked by indexer (maybe kodadot/rubick#279)

@exezbcz
Copy link
Member

exezbcz commented Jan 2, 2024

@roiLeo yup, lets remove it then

@roiLeo roiLeo removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jan 3, 2024
@vikiival
Copy link
Member

vikiival commented Jan 3, 2024

cc @prury ?

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 3, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 3, 2024

Code Climate has analyzed commit 7669fd4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Jan 3, 2024

Thanks!
pay 50 usd

@yangwao yangwao merged commit 5cb9f48 into kodadot:main Jan 3, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 3, 2024

😍 Perfect, I’ve sent the payout
💵 $50 @ 7.46 USD/DOT ~ 6.702 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0xc0101a84db039c53ef7de9d8269e2045c76170cd42bc11f0d21d3eee9d68e574

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 3, 2024
@hassnian hassnian deleted the issue-8816 branch January 4, 2024 03:11
This was referenced Jan 4, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@roiLeo roiLeo roiLeo approved these changes

@preschian preschian preschian approved these changes

@exezbcz exezbcz Awaiting requested review from exezbcz

Assignees
No one assigned
Labels
medium Pull request is medium paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add network filter to top collection
9 participants
@hassnian @kodabot @exezbcz @roiLeo @vikiival @yangwao @preschian @Jarsen136 @prury